Add the delete button in the edit form of an event #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just a personal observation, perhaps we can change the position of the delete button because having 3 buttons on the same row may be a bit confusing. |
trymebytes
previously requested changes
Feb 15, 2024
|
In a follow up PR, I'll suggest we have a single AJAX function handle all event form submissions. |
psrpinto
reviewed
Feb 15, 2024
I like to have all the buttons in the same row, with different styles (one specific for deleting), rather than having them in 2 rows.
|
Merged
amieiro
dismissed
trymebytes’s stale review
This will be improved in a future PR, not in this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the "Delete button"
Fixes #66